Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add parameters to subscription #25

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

elle-le
Copy link
Contributor

@elle-le elle-le commented Nov 15, 2024

@elle-le elle-le marked this pull request as ready for review November 22, 2024 13:37
@elle-le
Copy link
Contributor Author

elle-le commented Nov 25, 2024

things needs to be done:

  • extend e2e test for this feature
  • perform a local-kind test to create a resource with this feature

@mirzakopic
Copy link
Contributor

I had a look at the e2e tests while they were running. The import is failing and the subscription never materialized inside the subaccount. I will try to run this locally and see what is going on.
@elle-le Did you run tests locally to confirm it works for you? Just checking if this is possible flakiness.

@elle-le
Copy link
Contributor Author

elle-le commented Dec 16, 2024

I had a look at the e2e tests while they were running. The import is failing and the subscription never materialized inside the subaccount. I will try to run this locally and see what is going on. @elle-le Did you run tests locally to confirm it works for you? Just checking if this is possible flakiness.

I was not able to run locally as my IDE could not pick up the .env file that I provided and was complaining of missing env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants